Change in vdsm[master]: vmstats: do not catch unlikely ZeroDivisionError

danken at redhat.com danken at redhat.com
Fri Jun 19 14:47:28 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vmstats: do not catch unlikely ZeroDivisionError
......................................................................


vmstats: do not catch unlikely ZeroDivisionError

Nowadays, the only foreseeable reason to have ZeroDivisionError
in the vmstats functions, is when interval is zero.

This case is in turn very very unlikely, as it should
happen only in the extravagant case of two polling cycles racing
together, saving bad bugs in the sampling code.

So, drop the ZeroDivisionError from the handled
exception, and we add an explicit guard to be sure
we record these end-of-the-world-like cases.

Change-Id: I6c6719414d185a8b359b5d8a9f4a28ac87b64327
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40916
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vmstats.py
1 file changed, 17 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/40916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c6719414d185a8b359b5d8a9f4a28ac87b64327
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list