Change in vdsm[master]: virt: Rate limit epoll errors on untracked FDs

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri Jun 19 09:47:38 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: virt: Rate limit epoll errors on untracked FDs
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/42569/1/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 181:             self._handle_event(fileno, event)
Line 182:             if self._untrackedErrors > UNTRACKED_ERROR_RESTART_LIMIT:
Line 183:                 self.log.critical("Too many epoll errors happened."
Line 184:                                   "Taking down process")
Line 185:                 os.kill(os.getpid(), signal.SIGTERM)
don't we have a function for that somewhere?
Line 186:             elif (self._untrackedErrors > 0 and
Line 187:                   self._untrackedErrors % UNTRACKED_ERROR_COOLDOWN_LIMIT == 0):
Line 188:                 time.sleep(ERROR_RATE_LIMIT_SLEEP_TIME)
Line 189:         else:


-- 
To view, visit https://gerrit.ovirt.org/42569
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I654e5b828e2c05e8a86fa0e945be67cec014c110
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list