Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Jun 19 08:46:49 UTC 2015


Vinzenz Feenstra has uploaded a new change for review.

Change subject: virt: Forcibly unregister fds with errors from epoll
......................................................................

virt: Forcibly unregister fds with errors from epoll

To ensure that we do not get spammed with errors, we're now again
proactively trying to unregister events from epoll

Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Bug-Url: https://bugzilla.redhat.com/1226911
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
---
M vdsm/virt/vmchannels.py
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/42570/1

diff --git a/vdsm/virt/vmchannels.py b/vdsm/virt/vmchannels.py
index 9939546..ade79ca 100644
--- a/vdsm/virt/vmchannels.py
+++ b/vdsm/virt/vmchannels.py
@@ -69,6 +69,12 @@
                 self._untrackedErrors += 1
                 self.log.debug("Received %.08X. On fd removed by epoll.",
                                event)
+                # Try to forcibly remove this FD from EPOLL
+                # To really stop receiving events
+                try:
+                    self._epoll.unregister(fileno)
+                except IOError:
+                    pass
         elif (event & select.EPOLLIN):
             obj = self._channels.get(fileno, None)
             if obj:


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>


More information about the vdsm-patches mailing list