Change in vdsm[master]: StorageDomainManifest: introduce class heirarchy

alitke at redhat.com alitke at redhat.com
Thu Jun 18 16:50:11 UTC 2015


Adam Litke has posted comments on this change.

Change subject: StorageDomainManifest: introduce class heirarchy
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/41993/14/vdsm/storage/sd.py
File vdsm/storage/sd.py:

Line 304:         StorageDomainManifest objects can be constructed without side effects
Line 305:         but before the object can be used it must be bound to the storage it
Line 306:         represents.  The bind method must be implemented by descendant classes.
Line 307:         """
Line 308:         raise NotImplementedError()
> We don't need bind now.
hmm, thought I removed this... Not sure how it sneaked in.
Line 309: 
Line 310:     @property
Line 311:     def oop(self):
Line 312:         return oop.getProcessPool(self.sdUUID)


-- 
To view, visit https://gerrit.ovirt.org/41993
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list