Change in vdsm[master]: StorageDomainManifest: move logBlkSize

alitke at redhat.com alitke at redhat.com
Thu Jun 18 15:26:43 UTC 2015


Adam Litke has posted comments on this change.

Change subject: StorageDomainManifest: move logBlkSize
......................................................................


Patch Set 13:

(4 comments)

https://gerrit.ovirt.org/#/c/41996/13/tests/manifest_tests.py
File tests/manifest_tests.py:

Line 57
Line 58
Line 59
Line 60
Line 61
> path -> tmpdir
Done


Line 60: 
Line 61:     def test_getmetaparam(self):
Line 62:         with namedTemporaryDir() as tmpdir:
Line 63:             manifest = self.make_manifest(tmpdir)
Line 64:             # XXX: Replace this with a setter once it's available
> See bellow.
Done
Line 65:             manifest._metadata.update({sd.DMDK_SDUUID: manifest.sdUUID})
Line 66:             self.assertEquals(manifest.sdUUID,
Line 67:                               manifest.getMetaParam(sd.DMDK_SDUUID))
Line 68: 


Line 116: 
Line 117:     def test_getmetaparam(self):
Line 118:         with namedTemporaryDir() as tmpdir:
Line 119:             manifest = self.make_manifest(tmpdir)
Line 120:             # XXX: Replace this with a setter once it's available
> See above
Done
Line 121:             manifest._metadata.update({sd.DMDK_SDUUID: manifest.sdUUID})
Line 122:             self.assertEquals(manifest.sdUUID,
Line 123:                               manifest.getMetaParam(sd.DMDK_SDUUID))
Line 124: 


Line 124: 
Line 125:     def test_getblocksize(self):
Line 126:         with namedTemporaryDir() as tmpdir:
Line 127:             manifest = self.make_manifest(tmpdir)
Line 128:             # Test that we get 512 when no sizes are set
> Lets make this two tests - one the case you test here, other for the TODO, 
Done
Line 129:             self.assertEquals(512, manifest.logBlkSize)
Line 130:             self.assertEquals(512, manifest.phyBlkSize)
Line 131:             # TODO: Set new sizes and verify
Line 132: 


-- 
To view, visit https://gerrit.ovirt.org/41996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9b20e9c8c20fa5c151f7c86337bc54ab526e11
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list