Change in vdsm[master]: net: introducing KernelConfig

danken at redhat.com danken at redhat.com
Thu Jun 18 15:01:07 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: introducing KernelConfig
......................................................................


Patch Set 16: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/41973/16/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:

Line 358:     def _normalize_bonding_opts(self, config_copy):
Line 359:         for bond, bond_attr in config_copy.bonds.iteritems():
Line 360:             # TODO: globalize default bond options from Bond in models.py
Line 361:             normalized_opts = self._parse_bond_options(
Line 362:                 bond_attr.get('options', 'mode=802.3ad miimon=150'))
didn't you want to get rid of the default mode before taking this patch?

didn't you say that it fails a test of ours?
Line 363:             bond_attr['options'] = self._netinfo.bondOptsForIfcfg(
Line 364:                 normalized_opts)
Line 365: 
Line 366:     def _normalize_bonding_nics(self, config_copy):


-- 
To view, visit https://gerrit.ovirt.org/41973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list