Change in vdsm[master]: resize-lun: Support guids parameter in getDeviceList

danken at redhat.com danken at redhat.com
Thu Jun 18 10:01:06 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: resize-lun: Support guids parameter in getDeviceList
......................................................................


resize-lun: Support guids parameter in getDeviceList

Add optional "guids" parameter to getDeviceList. If specified,
getDevicesList will get info and test only these devices.

In the resize LUN flow, we need to rescan and resize the devices before
resizing the PV. Engine will invoke getDeviceList verb with specific
LUNs ids.

In getDeviceList we test PV creation and this is a heavyweight
operation, using the guids parameter we limit the operation to the
specified devices.

Examples:

    getDeviceList
        return all devices

    getDeviceList FCP
        return only FCP devices

    getDeviceList ISCSI guid1 guid2
        return info for guid1 and guid2, assuming ISCSI type

Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7
Bug-Url:https://bugzilla.redhat.com/609689
Signed-off-by: Fred Rolland <frolland at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40661
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Tested-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Jenkins CI
Continuous-Integration: Jenkins CI
Tested-by: Jenkins CI
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/bindingxmlrpc.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
5 files changed, 29 insertions(+), 11 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified; Looks good to me, but someone else must approve
  Federico Simoncelli: Looks good to me, approved
  Jenkins CI: Verified; Looks good to me, but someone else must approve; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/40661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list