Change in vdsm[master]: Added standard build skeleton

ybronhei at redhat.com ybronhei at redhat.com
Thu Jun 18 08:26:24 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: Added standard build skeleton
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/41928/3/automation/check-patch.req
File automation/check-patch.req:

Line 1: yum
> You can replace this with one call to yum builddep in check-patch.sh
because this is how ci scripts currently work and I don't plan to parse the spec but align to theirs instructions
Line 2: sudo
Line 3: dhclient
Line 4: autoreconf
Line 5: gettext-devel


https://gerrit.ovirt.org/#/c/41928/3/automation/check-patch.sh
File automation/check-patch.sh:

Line 1: #!/bin/bash -e
Line 2: #
Line 3: # Run on each patch to gerrit, should be faster than check-meged and require
Line 4: # less resources but thorough enough to provide relevant feedback
> David: we need more specific contract with the ci
not related to the patch
Line 5: 
Line 6: echo "Hello - ifra functional tests"
Line 7: 
Line 8: ./autogen.sh --system; make rpm NOSE_EXCLUDE=.*


Line 4: # less resources but thorough enough to provide relevant feedback
Line 5: 
Line 6: echo "Hello - ifra functional tests"
Line 7: 
Line 8: ./autogen.sh --system; make rpm NOSE_EXCLUDE=.*
> You do everything here except running the tests, which is the only thing we
wip , I know what I do and I need to update the commit message. the reason for this patch is to introduce functional tests job. I plan to run vdsmd and trigger tests/run_tests.sh functional/* -> those tests will depend on specific environment state and this job should create the needed state
Line 9: yum install ~/rpmbuild/RPMS/noarch/vdsm*
Line 10: 
Line 11: 
Line 12: vdsm-tool configure --force


-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list