Change in vdsm[master]: resize-lun: Add resize map support in multipath

Federico Simoncelli fsimonce at redhat.com
Wed Jun 17 22:06:48 UTC 2015


Federico Simoncelli has posted comments on this change.

Change subject: resize-lun: Add resize map support in multipath
......................................................................


Patch Set 18: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/40468/18/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:

Line 130:     Raises Error if multipathd failed to resize the map.
Line 131:     """
Line 132:     log.debug("Resizing map %r", name)
Line 133:     cmd = [_MULTIPATHD.cmd, "resize", "map", name]
Line 134:     start = utils.monotonic_time()
This could be a contextmanager (start/stop, logging time elapsed, etc.)
Line 135:     rc, out, err = utils.execCmd(cmd, raw=True, execCmdLogger=log)
Line 136:     # multipathd reports some errors using non-zero exit code and stderr (need
Line 137:     # to be root), but the command may return 0, and the result is reported
Line 138:     # using stdout.


-- 
To view, visit https://gerrit.ovirt.org/40468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1020667baeb5976fb1c78daedcc88727648f13d
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list