Change in vdsm[master]: spec: Make vdsm arch specific package

nsoffer at redhat.com nsoffer at redhat.com
Wed Jun 17 16:02:50 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: spec: Make vdsm arch specific package
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/42490/1/vdsm.spec.in
File vdsm.spec.in:

Line 311: tasks, statistics gathering, and log collection.
Line 312: 
Line 313: %package cli
Line 314: Summary:        VDSM command line interface
Line 315: BuildArch:      noarch
> not worth using global %arch instead of specifying noarch repeatedly?
I'm not sure what do you mean, but we must define the top level package without BuildArch, to allow usage of %ifarch/%ifnarch, needed to require or exclude certain dependencies on certain architectures.

The sub-packages must have their own BuildArch, so we have to specify each package.

See also https://bugzilla.redhat.com/show_bug.cgi?id=1133479#c13
Line 316: Requires: %{name}-python = %{version}-%{release}
Line 317: Requires: %{name}-xmlrpc = %{version}-%{release}
Line 318: 
Line 319: %description cli


-- 
To view, visit https://gerrit.ovirt.org/42490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbc71ccded31e8b80b14dbb03fd738694ceb37c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list