Change in vdsm[master]: Improve readability of _ownedIfcfg procedure

pzhukov at redhat.com pzhukov at redhat.com
Wed Jun 17 14:52:42 UTC 2015


Pavel Zhukov has posted comments on this change.

Change subject: Improve readability of _ownedIfcfg procedure
......................................................................


Patch Set 1:

(1 comment)

Petr, I don't understand you question. See inline comment (and original code). Thanks

https://gerrit.ovirt.org/#/c/42287/1/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 499:                 return content.startswith(self.CONFFILE_HEADER_BASE)
Line 500:         except IOError as e:
Line 501:             if e.errno != os.errno.ENOENT:
Line 502:                 raise
Line 503:         return False
> can this line ever happen?
e.error == os.errno.ENOENT ?
Line 504: 
Line 505:     def _ownedFiles(self):
Line 506:         for fpath in glob.iglob(netinfo.NET_CONF_DIR + '/*'):
Line 507:             if self._ownedIfcfg(fpath):


-- 
To view, visit https://gerrit.ovirt.org/42287
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f6e4aaf919a5bec26d297cf01d83b9adf6a9461
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list