Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
alitke at redhat.com
alitke at redhat.com
Wed Jun 17 13:41:41 UTC 2015
Adam Litke has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
......................................................................
Patch Set 27: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/40712/27/vdsm/virt/secret.py
File vdsm/virt/secret.py:
Line 43: secret.register(con)
Line 44: except libvirt.libvirtError as e:
Line 45: logging.error("Could not register secret %s: %s", secret, e)
Line 46: return response.error("secretRegisterErr")
Line 47:
It there's an error this could leave around some registered secrets although an error was returned.
Line 48: return response.success()
Line 49:
Line 50:
Line 51: def unregister(uuids):
--
To view, visit https://gerrit.ovirt.org/40712
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list