Change in vdsm[master]: virt: tolerate missing ovirt-vmconsole group

nsoffer at redhat.com nsoffer at redhat.com
Wed Jun 17 09:47:49 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: virt: tolerate missing  ovirt-vmconsole group
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/42451/2/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 102:             try:
Line 103:                 supervdsm.getProxy().prepareVmChannel(
Line 104:                     self._path,
Line 105:                     constants.OVIRT_VMCONSOLE_GROUP)
Line 106:             except KeyError:
KeyError is pretty bad error to check here, but this is stdlib fault.

We should fix this later in fileUtils, raise an error that cannot mask a bug in the calling code.
Line 107:                 self.log.warn('unknown group %s, permissions not updated',
Line 108:                               constants.OVIRT_VMCONSOLE_GROUP)
Line 109: 
Line 110:     def cleanup(self):


-- 
To view, visit https://gerrit.ovirt.org/42451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55b708953e5871053f0063bb82434c5c0dcb6103
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list