Change in vdsm[master]: gluster: Verify volume is Replica 3

nsoffer at redhat.com nsoffer at redhat.com
Tue Jun 16 20:59:43 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: gluster: Verify volume is Replica 3
......................................................................


Patch Set 27: -Code-Review -Verified

replica1 test fails when running on machine with custom replica 1 setting - typical developer machine.

======================================================================
FAIL: test_allowed_gluster_replica_count(kw='1') (storageServerTests.GlusterFSConnectionTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/src/vdsm/tests/testlib.py", line 64, in wrapper
    return f(self, *args)
  File "/root/src/vdsm/tests/monkeypatch.py", line 133, in wrapper
    return f(*args, **kw)
  File "/root/src/vdsm/tests/storageServerTests.py", line 149, in test_allowed_gluster_replica_count
    gluster.validate)
AssertionError: UnsupportedGlusterVolumeReplicaCountError not raised

The test must mock the configuration - we don't want test to depend on the current configuration on a host.

-- 
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list