Change in vdsm[master]: gluster: Allow gluster mount with additional servers

ahino at redhat.com ahino at redhat.com
Tue Jun 16 19:44:08 UTC 2015


Ala Hino has posted comments on this change.

Change subject: gluster: Allow gluster mount with additional servers
......................................................................


Patch Set 22:

(3 comments)

https://gerrit.ovirt.org/#/c/40665/22/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 286: 
Line 287:     @property
Line 288:     def options(self):
Line 289:         self._gluster_options = self._get_gluster_mount_options()
Line 290:         return ",".join(p for p in (self._options, self._gluster_options) if p)
> Why did you remove the lazy initialization here? it is valid only in the ne
Done
Line 291: 
Line 292:     def _get_gluster_mount_options(self):
Line 293:         if "backup-volfile-servers" in self._options:
Line 294:             self.log.warn("User specified mount options will be used.")


Line 288:     def options(self):
Line 289:         self._gluster_options = self._get_gluster_mount_options()
Line 290:         return ",".join(p for p in (self._options, self._gluster_options) if p)
Line 291: 
Line 292:     def _get_gluster_mount_options(self):
> Lets be more specific - we do not compute here the gluster mount options, b
Done
Line 293:         if "backup-volfile-servers" in self._options:
Line 294:             self.log.warn("User specified mount options will be used.")
Line 295:             return ""
Line 296: 


Line 290:         return ",".join(p for p in (self._options, self._gluster_options) if p)
Line 291: 
Line 292:     def _get_gluster_mount_options(self):
Line 293:         if "backup-volfile-servers" in self._options:
Line 294:             self.log.warn("User specified mount options will be used.")
> Lets be more specific about the warning:
Done
Line 295:             return ""
Line 296: 
Line 297:         volfileServer, volname = self._remotePath.split(":", 1)
Line 298:         volname = volname.strip('/')


-- 
To view, visit https://gerrit.ovirt.org/40665
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list