Change in vdsm[ovirt-3.5]: protocoldetecor: SSLError handled not correctly

ybronhei at redhat.com ybronhei at redhat.com
Tue Jun 16 14:38:18 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: protocoldetecor: SSLError handled not correctly
......................................................................


protocoldetecor: SSLError handled not correctly

Whenever there was ssl issue during protocol detection the code entered
infinite loop because we haven't remove fd from pending_connections.
It is fixed by caching SSLError reading data and clean up fd correctly.


Label: ovirt-3.5-only
Change-Id: I8ea5c305b19c0a7421ea74e069c3ad02d9ffd141
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Bug-Url: https://bugzilla.redhat.com/1229859
Bug-Url: https://bugzilla.redhat.com/1215236
Reviewed-on: https://gerrit.ovirt.org/42206
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/protocoldetector.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/42206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ea5c305b19c0a7421ea74e069c3ad02d9ffd141
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list