Change in vdsm[master]: net: introducing KernelConfig

danken at redhat.com danken at redhat.com
Tue Jun 16 13:32:00 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: introducing KernelConfig
......................................................................


Patch Set 13:

(2 comments)

https://gerrit.ovirt.org/#/c/41973/13/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:

Line 258:         if vlan is not None:
Line 259:             attributes['vlan'] = str(vlan)
Line 260: 
Line 261:     def _translate_mtu(self, attributes, net_attr):
Line 262:         if net_attr['mtu'] != self._netinfo.getDefaultMtu():
if 'mtu' not in net_attr:
  attributes['mtu'] = self._netinfo.getDefaultMtu()
Line 263:             attributes['mtu'] = net_attr['mtu']
Line 264: 
Line 265:     def _translate_bridged(self, attributes, net_attr):
Line 266:         attributes['bridged'] = net_attr['bridged']


Line 263:             attributes['mtu'] = net_attr['mtu']
Line 264: 
Line 265:     def _translate_bridged(self, attributes, net_attr):
Line 266:         attributes['bridged'] = net_attr['bridged']
Line 267:         if net_attr['bridged'] and net_attr['stp'] == 'on':
how can this pass the test where "True" is passed to setupNetwork?
Line 268:             attributes['stp'] = net_attr['stp']
Line 269: 
Line 270:     def _translate_netinfo_bond(self, bond_attr):
Line 271:         return {


-- 
To view, visit https://gerrit.ovirt.org/41973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list