Change in vdsm[master]: gluster: Allow gluster mount with additional servers
nsoffer at redhat.com
nsoffer at redhat.com
Tue Jun 16 12:08:48 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: gluster: Allow gluster mount with additional servers
......................................................................
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/40665/19/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 299: return ""
Line 300:
Line 301: volfileServer, volname = self._remotePath.split(":", 1)
Line 302: volname = volname.strip('/')
Line 303: volInfo = supervdsm.getProxy().glusterVolumeInfo(volname,
> This call might raise some exception. can it be handled suitably?
Ala, check how NFSConnection is handling such fatal failures.
If we have a suitable error in storage_exception.py we can log the original traceback and raise the storage_exception error, so the engine can show one of the translated error messages.
If we don't handle errors here, we will get a very clear traceback in vdsm log, and engine will show a generic error message. This may be a fine way to handle the error.
Line 304: volfileServer)
Line 305: servers = [brick.split(":")[0]
Line 306: for brick in volInfo[volname]['bricks']]
Line 307: servers.remove(volfileServer)
--
To view, visit https://gerrit.ovirt.org/40665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list