Change in vdsm[master]: gluster: Verify volume is Replica 3

nsoffer at redhat.com nsoffer at redhat.com
Tue Jun 16 11:07:04 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: gluster: Verify volume is Replica 3
......................................................................


Patch Set 20:

(2 comments)

https://gerrit.ovirt.org/#/c/41931/20//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Verify that only Replica 3 volumes are used in gluster storage domains.
Line 10: We enforce replica 3 because this is the recommended deployment for virt
Line 11: and gluster.
Line 12: We added a configuration mainly to enable developers test gluster without
What do you mean by "mainly"? I think this is the only reason for adding the configuration, and you can remove this word.
Line 13: the need to create replica 3 volumes.
Line 14: 
Line 15: Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
Line 16: Bug-Url: https://bugzilla.redhat.com/1123052


https://gerrit.ovirt.org/#/c/41931/20/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 302:             self._gluster_options = self._get_gluster_mount_options()
Line 303:         comma = ','
Line 304:         if self._options is "" or self._gluster_options is "":
Line 305:             comma = ""
Line 306:         return self._options + comma + self._gluster_options
This works, but we do it in a pythonic way, similar to NFSConnection:

    return ",".join(filter(None, (self._options, self._gluster_options)))

Another more modern way:

    return ",".join(p for p in (self._options, self._gluster_options) if p)
Line 307: 
Line 308:     @property
Line 309:     def volinfo(self):
Line 310:         if self._volinfo is None:


-- 
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list