Change in vdsm[master]: net: introducing KernelConfig

ibarkan at redhat.com ibarkan at redhat.com
Tue Jun 16 10:30:25 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: introducing KernelConfig
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/41973/5/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 925: @staticmethod
> I would prefer not to have simple accessor functions :-)
me to. but sadly, you cannot import netinfo.py from netconfpersistence.py because of a circular import.


https://gerrit.ovirt.org/#/c/41973/5/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 425: status, msg = self.setupNetworks(networks, bondings, NOCHK)
> Did I understand from comments on the previous patch set that you are going
done. see https://gerrit.ovirt.org/42309


-- 
To view, visit https://gerrit.ovirt.org/41973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list