Change in vdsm[master]: migration: raise and except only specific exceptions

danken at redhat.com danken at redhat.com
Tue Jun 16 10:20:28 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: migration: raise and except only specific exceptions
......................................................................


migration: raise and except only specific exceptions

Right now on migration over JsonRpc we swallow
any RuntimeError, when actually we might need to fail
the migration.
To avoid this we will do except clause only for
very specific JsonRpcErrors.

Change-Id: I4cf662d99493921910821f263b6a5a4542d1604f
Signed-off-by: Yeela Kaplan <ykaplan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/42385
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/jsonrpcvdscli.py
M lib/yajsonrpc/__init__.py
M vdsm/clientIF.py
M vdsm/virt/migration.py
4 files changed, 23 insertions(+), 6 deletions(-)

Approvals:
  Yeela Kaplan: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42385
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4cf662d99493921910821f263b6a5a4542d1604f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list