Change in vdsm[master]: Separate MOM to an external process

danken at redhat.com danken at redhat.com
Mon Jun 15 14:40:25 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Separate MOM to an external process
......................................................................


Separate MOM to an external process

MOM won't be started as an internal thread anymore. Its preconfigured
instance will be started as systemd service instead.

VDSM will keep communicating with MOM as usual over MOM's RPC interface.
This also updates setKsmTune to be logged only in TRACE mode to avoid
log pollution.

New mom-vdsm service requires VDSM to be Up and uses the config file
/etc/vdsm/mom.conf. It also exposes its own RPC using unix domain
socket /var/run/vdsm/mom-vdsm.sock.

mom-vdsm will be restarted when vdsmd restarts and started when
vdsmd starts (but errors in mom-vdsm do not propagate to vdsmd).

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1227714
Change-Id: I99b81d21080834b7031824dab0a26f45e7eac7af
Signed-off-by: Martin Sivak <msivak at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/41602
Reviewed-by: Francesco Romani <fromani at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M .gitignore
M init/systemd/Makefile.am
A init/systemd/mom-vdsm.service.in
M init/systemd/vdsmd.service.in
M tests/Makefile.am
A tests/momTests.py
M vdsm.spec.in
M vdsm/clientIF.py
M vdsm/mom.conf.in
M vdsm/momIF.py
M vdsm/rpc/bindingxmlrpc.py
11 files changed, 252 insertions(+), 39 deletions(-)

Approvals:
  Martin Sivák: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/41602
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99b81d21080834b7031824dab0a26f45e7eac7af
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list