Change in vdsm[master]: gluster: Verify volume is Replica 3

nsoffer at redhat.com nsoffer at redhat.com
Mon Jun 15 10:17:19 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: gluster: Verify volume is Replica 3
......................................................................


Patch Set 15:

(3 comments)

https://gerrit.ovirt.org/#/c/41931/15/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 278:     #       - 21692 /usr/bin/glusterfs ...
Line 279:     #
Line 280:     CGROUP = "vdsm-glusterfs"
Line 281:     DIR = "glusterSD"
Line 282:     ALLOWED_REPLICA_COUNT = [int(c) for c in
COUNTS
Line 283:             config.get("gluster", "allowed_replica_count").split(",")]
Line 284: 
Line 285:     def __init__(self,
Line 286:                  spec,


Line 279:     #
Line 280:     CGROUP = "vdsm-glusterfs"
Line 281:     DIR = "glusterSD"
Line 282:     ALLOWED_REPLICA_COUNT = [int(c) for c in
Line 283:             config.get("gluster", "allowed_replica_count").split(",")]
...replica_counts - its a list
Line 284: 
Line 285:     def __init__(self,
Line 286:                  spec,
Line 287:                  vfsType=None,


Line 309:         return self._volinfo
Line 310: 
Line 311:     def validate(self):
Line 312:         replicaCount = self.volinfo[self._volname]['replicaCount']
Line 313:         if not replicaCount in self.ALLOWED_REPLICA_COUNT:
replicaCount not in ...
Line 314:             raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
Line 315: 
Line 316:     def _get_gluster_mount_options(self):
Line 317:         if "backup-volfile-servers" in self._options:


-- 
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list