Change in vdsm[master]: migration: Use jsonrpc during migration of vms
danken at redhat.com
danken at redhat.com
Mon Jun 15 10:04:38 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: migration: Use jsonrpc during migration of vms
......................................................................
Patch Set 19: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/36701/19/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 129: self.remoteHost, port = hostPort.rsplit(':', 1)
Line 130:
Line 131: try:
Line 132: client = self._createClient(port)
Line 133: self._destServer = jsonrpcvdscli.connect(client)
which of these many command is raising the RuntimeError?
Can you make the try-block shorter?
RuntimeError is quite general - I would like to fallback to xmlrpc only on a very spesific failure.
Line 134: self.log.debug('Initiating connection with destination')
Line 135: self._destServer.ping()
Line 136:
Line 137: except RuntimeError:
--
To view, visit https://gerrit.ovirt.org/36701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list