Change in vdsm[ovirt-3.5]: protocoldetecor: SSLError handled not correctly

nsoffer at redhat.com nsoffer at redhat.com
Mon Jun 15 09:06:21 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: protocoldetecor: SSLError handled not correctly
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/42206/4/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:

Line 231:             return
Line 232:         except (SSL.SSLError, socket.error) as e:
Line 233:             if getattr(e, "errno", 0) not in (errno.EAGAIN, errno.EWOULDBLOCK):
Line 234:                 self._remove_connection(client_socket)
Line 235:                 client_socket.close()
Why do you duplicate the error handling? This expect block should *replace* the previous one.
Line 236:             return
Line 237: 
Line 238:         if data is None:
Line 239:             # None is returned when ssl socket needs to read more data


-- 
To view, visit https://gerrit.ovirt.org/42206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea5c305b19c0a7421ea74e069c3ad02d9ffd141
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list