Change in vdsm[master]: Separate MOM to an external process

msivak at redhat.com msivak at redhat.com
Mon Jun 15 07:14:46 UTC 2015


Martin Sivák has posted comments on this change.

Change subject: Separate MOM to an external process
......................................................................


Patch Set 17:

(3 comments)

https://gerrit.ovirt.org/#/c/41602/17/tests/momTests.py
File tests/momTests.py:

Line 1: from unittest import TestCase
> missing license boilerplate. I don't really care, legal can :)
Done
Line 2: import threading
Line 3: import ConfigParser
Line 4: from momIF import MomClient
Line 5: from caps import PAGE_SIZE_BYTES


https://gerrit.ovirt.org/#/c/41602/17/vdsm/momIF.py
File vdsm/momIF.py:

Line 23: xmlrpclib
> And this can be probably removed as well.
Done


Line 26: from vdsm.define import Mbytes
Line 27: 
Line 28: try:
Line 29:     import mom
Line 30:     from mom import unixrpc
> this seems redundant. Can't we just use mom.unixrpc below?
Nope, it is a separate file that is not exposed from mom.__init__.
Line 31:     _momAvailable = True
Line 32: except ImportError:
Line 33:     _momAvailable = False
Line 34: 


-- 
To view, visit https://gerrit.ovirt.org/41602
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99b81d21080834b7031824dab0a26f45e7eac7af
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list