Change in vdsm[master]: storage: Add resize map support in multipath.py

nsoffer at redhat.com nsoffer at redhat.com
Sun Jun 14 16:52:28 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: Add resize map support in multipath.py
......................................................................


Patch Set 14: Code-Review+1

(2 comments)

https://gerrit.ovirt.org/#/c/40468/14/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:

Line 84:     udevadm.settle(timeout)
Line 85: 
Line 86: 
Line 87: def resize_devices():
Line 88:     # This is needed in case a device has been increased on the storage server
Replace this comment with a docstring - take the docstring from _resize_if_needed which is private now, and does not require a docstring.
Line 89:     for dmId, guid in getMPDevsIter():
Line 90:         try:
Line 91:             _resize_if_needed(guid)
Line 92:         except Exception:


Line 136:     cmd = [_MULTIPATHD.cmd, "resize", "map", name]
Line 137:     start = utils.monotonic_time()
Line 138:     rc, out, err = utils.execCmd(cmd, raw=True, execCmdLogger=log)
Line 139:     # multipathd reports some errors using non-zero exit code and stderr (need
Line 140:     # to be root), but -k commands always return 0, and the result is reported
We are not using -k now, please update to describe the current code.
Line 141:     # using stdout.
Line 142:     if rc != 0 or out != "ok\n":
Line 143:         raise Error("Resizing map %r failed: out=%r err=%r"
Line 144:                     % (name, out, err))


-- 
To view, visit https://gerrit.ovirt.org/40468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1020667baeb5976fb1c78daedcc88727648f13d
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list