Change in vdsm[master]: daemonAdapter: remove traceback when using help option

dkuznets at redhat.com dkuznets at redhat.com
Sun Jun 14 12:22:47 UTC 2015


Dima Kuznetsov has posted comments on this change.

Change subject: daemonAdapter: remove traceback when using help option
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/42147/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-06-10 14:31:13 +0300
Line 4: Commit:     Yeela Kaplan <ykaplan at redhat.com>
Line 5: CommitDate: 2015-06-10 14:33:46 +0300
Line 6: 
Line 7: daemonAdapter: remove traceback when using help option
> why does the help option raise exception at all ?
argparser executes the built-in --help, which calls sys.exit(?).

The except clause without type caught the SystemExit exception (which is not a subtype of Exception so it should be ok now).
Line 8: 
Line 9: Change-Id: I7c592d73fb72112839b83794fd737967b2c92600
Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120787


-- 
To view, visit https://gerrit.ovirt.org/42147
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c592d73fb72112839b83794fd737967b2c92600
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list