Change in vdsm[master]: WIP: Remove Vdsm's dependency on gluster-server package.

dnarayan at redhat.com dnarayan at redhat.com
Sun Jun 14 12:10:40 UTC 2015


Darshan N has posted comments on this change.

Change subject: WIP: Remove Vdsm's dependency on gluster-server package.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/41568/2/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 30: from storage import glusterUtils as gu
Line 31: 
Line 32: _glusterCommandPath = utils.CommandPath("gluster",
Line 33:                                         "/usr/sbin/gluster",
Line 34:                                         )
> Should be removed as its no longer used...
Done
Line 35: _TIME_ZONE = time.tzname[0]
Line 36: 
Line 37: 
Line 38: if hasattr(etree, 'ParseError'):


https://gerrit.ovirt.org/#/c/41568/2/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 419:     def set_rp_filter_loose(self, dev):
Line 420:         sysctl.set_rp_filter_loose(dev)
Line 421: 
Line 422:     @logDecorator
Line 423:     def volumeInfo(self, remoteServer, volumeName=None):
> This is gluster specific verb, should be named glusterVolumeInfo.
Done
Line 424:         return glusterUtils.volumeInfo(remoteServer, volumeName)
Line 425: 
Line 426:     @logDecorator
Line 427:     def set_rp_filter_strict(self, dev):


-- 
To view, visit https://gerrit.ovirt.org/41568
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list