Change in vdsm[master]: gluster: Verify volume is Replica 3

nsoffer at redhat.com nsoffer at redhat.com
Sun Jun 14 11:05:09 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: gluster: Verify volume is Replica 3
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/41931/8/tests/storageServerTests.py
File tests/storageServerTests.py:

Line 113:         self.assertEquals(gluster.options,
Line 114:                           "backup-volfile-servers=192.168.122.2:192.168.122.3")
Line 115: 
Line 116:     @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 117:     def testUserProvidedGlusterMountOptions(self):
Use lowercase names
Line 118: 
Line 119:         def glusterVolumeInfo(volname=None, volfileServer=None):
Line 120:             return None
Line 121: 


Line 126:                                       options=user_options)
Line 127:         self.assertEquals(gluster.options, user_options)
Line 128: 
Line 129:     @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 130:     def testNotReplica3GlusterVolume(self):
Use lowercase names
Line 131: 
Line 132:         def glusterVolumeInfo(volumeName=None, remoteServer=None):
Line 133:             return {'music': {'brickCount': '2',
Line 134:                               'bricks': ['192.168.122.1:/tmp/music',


-- 
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list