Change in vdsm[master]: gluster: handle partition table corruption error

tjeyasin at redhat.com tjeyasin at redhat.com
Sat Jun 13 03:53:34 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: handle partition table corruption error
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/42210/2/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 42: 
Line 43: log = logging.getLogger("Gluster")
Line 44: 
Line 45: try:
Line 46:     blivet.util.set_up_logging("/var/log/blivet.log")
> 1. Why do you need to set logger?
Logs are created/updated only after we set the logger. The default path is "/tmp/blivet.log". Currently blivet does not support log level for any OS. Its under development. http://paste.fedoraproject.org/231541/43412650/. I have chosen /var/log directory because i found anaconda logs are also present there. However /var/log/vdsm could be the best suitable place as vdsm is using blivet. I will change the directory to /var/log/vdsm/blivet.log
Line 47: except AttributeError:
Line 48:     pass
Line 49: 
Line 50: _lvconvertCommandPath = utils.CommandPath("lvconvert",


Line 117:     try:
Line 118:         blivetEnv.reset()
Line 119:     except blivet.errors.UnusableConfigurationError as e:
Line 120:         log.error("Error: %s" % e.message)
Line 121:     except blivet.errors.StorageError as e:
> except (blivet.errors.UnusableConfigurationError, blivet.errors.StorageErro
Done
Line 122:         log.error("Error: %s" % e.message)
Line 123: 
Line 124: 
Line 125: @makePublic


-- 
To view, visit https://gerrit.ovirt.org/42210
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb3d42091b69f052ae93bbb114f9d3b9d158be4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list