Change in vdsm[master]: status: logging status values before sending event

fromani at redhat.com fromani at redhat.com
Fri Jun 12 12:09:23 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: status: logging status values before sending event
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/41380/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 403:                 if 'exitReason' in self.conf:
Line 404:                     stats['exitReason'] = self.conf['exitReason']
Line 405: 
Line 406:             self.log.debug('Last status %s and evaluated status %s',
Line 407:                            self.lastStatus, vm_status)
> i believe we do want to log both to understand the inter-dependencies
Totally agree, but why don't log also evaluatedStatus, then?
Line 408:             self._notify('VM_status', stats)
Line 409: 
Line 410:     def _notify(self, operation, params):
Line 411:         sub_id = '|virt|%s|%s' % (operation, self.id)


-- 
To view, visit https://gerrit.ovirt.org/41380
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e266759ba0310dd83d6b65d9e3a63caacc0b637
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list