Change in vdsm[master]: virt: Trigger event on guest agent status changes
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Fri Jun 12 10:52:46 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: virt: Trigger event on guest agent status changes
......................................................................
Patch Set 18:
(3 comments)
https://gerrit.ovirt.org/#/c/41108/18/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:
Line 115: self.log = log
Line 116: self._socketName = socketName
Line 117: self._sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
Line 118: self._stopped = True
Line 119: self._lastGuestStatus = None
> if possible, would you name it plainly
Done
Line 120: self.guestDiskMapping = {}
Line 121: self.guestInfo = {
Line 122: 'username': user,
Line 123: 'memUsage': 0,
https://gerrit.ovirt.org/#/c/41108/18/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 331: self._guestSocketFile = self._makeChannelPath(_VMCHANNEL_DEVICE_NAME)
Line 332: self._qemuguestSocketFile = self._makeChannelPath(_QEMU_GA_DEVICE_NAME)
Line 333: self.guestAgent = guestagent.GuestAgent(
Line 334: self._guestSocketFile, self.cif.channelListener, self.log,
Line 335: self._agent_status_changed)
> we could pass self.send_status_event directly.
Done
Line 336: self._domain = DomainDescriptor.from_id(self.id)
Line 337: self._released = False
Line 338: self._releaseLock = threading.Lock()
Line 339: self.saveState()
Line 353: self._numaInfo = {}
Line 354: self._vmJobs = None
Line 355:
Line 356: def _agent_status_changed(self):
Line 357: self._send_status_event()
> typo?
Done
Line 358:
Line 359: def _get_lastStatus(self):
Line 360: # note that we don't use _statusLock here. One of the reasons is the
Line 361: # non-obvious recursive locking in the following flow:
--
To view, visit https://gerrit.ovirt.org/41108
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaceca8e42720df50d5eb1e20670b6ed733db8b50
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list