Change in vdsm[master]: stomp: outgoing connection to a broker
danken at redhat.com
danken at redhat.com
Fri Jun 12 09:06:39 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
......................................................................
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/38819/30/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 180: 'Enable HTTP/1.1 keep-alive connections'),
Line 181:
Line 182: ('jsonrpc_enable', 'true', 'Enable the JSON RPC server'),
Line 183:
Line 184: ('broker_enable', 'false', 'Enable outgoing connection to broker'),
this is "false" by default, and I am not aware of plans to make it "true" during 3.6 version.
Could you take this patch off the critical branch?
I would like to spend more time understanding why Vdsm needs to know about its broker's subscriptions.
Line 185:
Line 186: ('report_host_threads_as_cores', 'false',
Line 187: 'Count each cpu hyperthread as an individual core'),
Line 188:
--
To view, visit https://gerrit.ovirt.org/38819
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list