Change in vdsm[master]: v2v: add mount windows iso drivers

fromani at redhat.com fromani at redhat.com
Thu Jun 11 14:14:46 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: v2v: add mount windows iso drivers
......................................................................


Patch Set 2:

(5 comments)

a few spelling mistakes, but nothing really suspicious. One question inside, so keeping my -1 for another round.

https://gerrit.ovirt.org/#/c/42128/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-06-10 13:08:20 +0300
Line 6: 
Line 7: v2v: add mount windows iso drivers
Line 8: 
Line 9: virt-v2v expect proprietary Windows drivers that is raise in
"is raise"?
Line 10: /usr/share/virtio-win.
Line 11: virtio-win cannot be a part of oVirt installation because of licencing
Line 12: issue.
Line 13: User that will want to use this drivers will upload the iso to iso


Line 7: v2v: add mount windows iso drivers
Line 8: 
Line 9: virt-v2v expect proprietary Windows drivers that is raise in
Line 10: /usr/share/virtio-win.
Line 11: virtio-win cannot be a part of oVirt installation because of licencing
licensing
Line 12: issue.
Line 13: User that will want to use this drivers will upload the iso to iso
Line 14: domain and the engine will provide the path to mountV2VWindowsDrivers
Line 15: which will in term will mount the iso in the location that virt-v2v


Line 11: virtio-win cannot be a part of oVirt installation because of licencing
Line 12: issue.
Line 13: User that will want to use this drivers will upload the iso to iso
Line 14: domain and the engine will provide the path to mountV2VWindowsDrivers
Line 15: which will in term will mount the iso in the location that virt-v2v
maybe "in turn will mount"?
Line 16: expected to be.
Line 17: 
Line 18: Change-Id: I6d4d19a63dcf338f8d48f8e757d6a35ef92d6d54


Line 13: User that will want to use this drivers will upload the iso to iso
Line 14: domain and the engine will provide the path to mountV2VWindowsDrivers
Line 15: which will in term will mount the iso in the location that virt-v2v
Line 16: expected to be.
Line 17: 
"expect them to be"?
Line 18: Change-Id: I6d4d19a63dcf338f8d48f8e757d6a35ef92d6d54


https://gerrit.ovirt.org/#/c/42128/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 49: _jobs = {}
Line 50: 
Line 51: _V2V_DIR = os.path.join(P_VDSM_RUN, 'v2v')
Line 52: _VIRT_V2V = CommandPath('virt-v2v', '/usr/bin/virt-v2v')
Line 53: _WIN_DRIVER_DIR = '/usr/share/virtio-win'
do we want this hardcoded?
Line 54: 
Line 55: ImportProgress = namedtuple('ImportProgress',
Line 56:                             ['current_disk', 'disk_count', 'description'])
Line 57: DiskProgress = namedtuple('DiskProgress', ['progress'])


-- 
To view, visit https://gerrit.ovirt.org/42128
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d4d19a63dcf338f8d48f8e757d6a35ef92d6d54
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list