Change in vdsm[master]: gluster: handle partition table corruption error

barumuga at redhat.com barumuga at redhat.com
Thu Jun 11 12:54:34 UTC 2015


Bala.FA has posted comments on this change.

Change subject: gluster: handle partition table corruption error
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/42210/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 40: from . import makePublic
Line 41: 
Line 42: 
Line 43: log = logging.getLogger("Gluster")
Line 44: blivet.util.set_up_logging()
> Currently blivet log to /tmp only. They have not yet implement the logging 
Are you sure the location can't be changed?
Line 45: _lvconvertCommandPath = utils.CommandPath("lvconvert",
Line 46:                                           "/sbin/lvconvert",
Line 47:                                           "/usr/sbin/lvconvert",)
Line 48: _lvchangeCommandPath = utils.CommandPath("lvchange",


Line 117: error
As this try-except is repeating, have a function like

def _reset_blivet(blivetEnv):
    try:
...
...


-- 
To view, visit https://gerrit.ovirt.org/42210
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb3d42091b69f052ae93bbb114f9d3b9d158be4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list