Change in vdsm[master]: Separate MOM to an external process

msivak at redhat.com msivak at redhat.com
Thu Jun 11 12:31:21 UTC 2015


Martin Sivák has posted comments on this change.

Change subject: Separate MOM to an external process
......................................................................


Patch Set 14:

(2 comments)

https://gerrit.ovirt.org/#/c/41602/14/tests/momTests.py
File tests/momTests.py:

Line 6: from momIF import MomClient
Line 7: from caps import PAGE_SIZE_BYTES
Line 8: from vdsm.define import Mbytes
Line 9: 
Line 10: MOM_CONF = os.path.join(os.path.dirname(__file__), "../vdsm/mom.conf")
> are sure this relative path works when vdsm-tests package is installed and 
Actually.. no, I did not know we install the tests as well. Any idea about how to get the proper config file path?
Line 11: MOM_PORT = 54323
Line 12: 
Line 13: 
Line 14: class DummyMomApi(object):


https://gerrit.ovirt.org/#/c/41602/14/vdsm/momIF.py
File vdsm/momIF.py:

Line 51:         if port == "-1":
Line 52:             self.log.error("MOM's RPC interface is disabled")
Line 53:             raise MomNotAvailableError()
Line 54: 
Line 55:         self._mom = xmlrpclib.ServerProxy("http://localhost:" + port)
> this is not very safe - every user on the host (I hope that only on the hos
MOM does not support that, so unfortunately No and No.

It is a loopback server so no, it is not exposed to the outside world. Are there any use cases where the host is used in multiuser environment? If not then I suggest we start with this and open an enhancement bug on mom so we can use something like https://github.com/tmbx/kpython/blob/master/kxmlrpc.py for example.
Line 56:         self._policy = {}
Line 57: 
Line 58:     def getKsmStats(self):
Line 59:         """


-- 
To view, visit https://gerrit.ovirt.org/41602
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99b81d21080834b7031824dab0a26f45e7eac7af
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list