Change in vdsm[master]: virt: memory hotplug for vm
ofrenkel at redhat.com
ofrenkel at redhat.com
Thu Jun 11 11:54:28 UTC 2015
Omer Frenkel has posted comments on this change.
Change subject: virt: memory hotplug for vm
......................................................................
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/40549/7/vdsm/vdsmd.8.in
File vdsm/vdsmd.8.in:
Line 134: The environment of hooks specific to devices:
Line 135: before_nic_hotplug, after_nic_hotplug, after_nic_hotplug_fail,
Line 136: before_nic_hotunplug, after_nic_hotunplug, after_nic_hotunplug_fail,
Line 137: before_update_device, after_update_device, after_update_device_fail,
Line 138: before_disk_hotplug, after_disk_hotplug,
> I think that your new memory hooks should be added here, too. right?
Done
Line 139: before_disk_hotunplug, after_disk_hotunplug,
Line 140: before_device_create, after_device_create,
Line 141: before_device_destroy, after_device_destroy,
Line 142: before_device_migrate_source, after_device_migrate_source,
https://gerrit.ovirt.org/#/c/40549/7/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:
Line 65: return elements[0] if elements else None
Line 66:
Line 67: def get_memory_size(self):
Line 68: """
Line 69: Return the vm memory from xml in mb
> mb -> MiB
Done
Line 70: """
Line 71: memory = self._first_element_by_tag_name("memory")
Line 68: """
Line 69: Return the vm memory from xml in mb
Line 70: """
Line 71: memory = self._first_element_by_tag_name("memory")
Line 72: return long(memory.firstChild.nodeValue) / 1024 if memory else None
> 'long' is probably unneeded.
Done
https://gerrit.ovirt.org/#/c/40549/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2210: self._devices[hwclass.MEMORY].append(device)
Line 2211: with self._confLock:
Line 2212: self.conf['devices'].append(memParams)
Line 2213: self._updateDomainDescriptor()
Line 2214: self._getUnderlyingMemoryDeviceInfo()
> Please add a comment:
Done
Line 2215: self.saveState()
Line 2216:
Line 2217: hooks.after_memory_hotplug(deviceXml)
Line 2218:
--
To view, visit https://gerrit.ovirt.org/40549
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list