Change in vdsm[master]: Separate MOM to an external process

danken at redhat.com danken at redhat.com
Thu Jun 11 11:52:38 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: Separate MOM to an external process
......................................................................


Patch Set 14: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/41602/14/vdsm/momIF.py
File vdsm/momIF.py:

Line 51:         if port == "-1":
Line 52:             self.log.error("MOM's RPC interface is disabled")
Line 53:             raise MomNotAvailableError()
Line 54: 
Line 55:         self._mom = xmlrpclib.ServerProxy("http://localhost:" + port)
this is not very safe - every user on the host (I hope that only on the host...) can now call mom's setPolicy and play dirty tricks.

Can mom listen on a vdsm-owned Unix domain socket?

Can it use vdsm's private key for https?
Line 56:         self._policy = {}
Line 57: 
Line 58:     def getKsmStats(self):
Line 59:         """


-- 
To view, visit https://gerrit.ovirt.org/41602
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99b81d21080834b7031824dab0a26f45e7eac7af
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list