Change in vdsm[master]: Add support for KSM and CpuTune calls to XMLRPC for MOM to use
danken at redhat.com
danken at redhat.com
Thu Jun 11 11:48:11 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: Add support for KSM and CpuTune calls to XMLRPC for MOM to use
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/41571/8/vdsm/API.py
File vdsm/API.py:
Line 1646: def setKsmTune(self, tuningParams):
Line 1647: try:
Line 1648: supervdsm.getProxy().ksmTune(tuningParams)
Line 1649: return dict(status=doneCode)
Line 1650: except:
I resent this catch-all "except", even though an existing piece of code two lines above already has it.
At the very least, please include a
logging.exception('bla')
so we can understand what's wrong in case ksmTune() has a SyntaxError one day.
Line 1651: return errCode['ksmErr']
Line 1652:
Line 1653: def setHaMaintenanceMode(self, mode, enabled):
Line 1654: """
--
To view, visit https://gerrit.ovirt.org/41571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd318b50abf8605c2584cb3b5316e2ca2ac4f5ef
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list