Change in vdsm[master]: virt: memory hotplug for vm

fromani at redhat.com fromani at redhat.com
Thu Jun 11 10:34:15 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: memory hotplug for vm
......................................................................


Patch Set 7:

(1 comment)

Good enough for me once Dan's comments are addressed

https://gerrit.ovirt.org/#/c/40549/7/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:

Line 68:         """
Line 69:         Return the vm memory from xml in mb
Line 70:         """
Line 71:         memory = self._first_element_by_tag_name("memory")
Line 72:         return long(memory.firstChild.nodeValue) / 1024 if memory else None
'long' is probably unneeded.


-- 
To view, visit https://gerrit.ovirt.org/40549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list