Change in vdsm[master]: stomp: add an option to create a stomp client

ybronhei at redhat.com ybronhei at redhat.com
Thu Jun 11 09:31:51 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: add an option to create a stomp client
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/38491/12/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 439:     def createStompClient(self, client_socket):
Line 440:         try:
Line 441:             json_binding = self.bindings['jsonrpc']
Line 442:         except KeyError:
Line 443:             raise RuntimeError("json rpc server is not available")
you can easily check "if 'jsonrpc' in self.bindings" .. more elegant . please change.

so the code can be:

 if 'jsonrpc' in self.bindings:
  return  self.bindinds['jsonrpc'].reactor.createClient(client_socket)
 else
  Raise RuntimeError("request for stompClient received but  stomp is not configured properly in vdsm")
Line 444:         reactor = json_binding.reactor
Line 445:         return reactor.createClient(client_socket)
Line 446: 
Line 447:     @utils.traceback()


-- 
To view, visit https://gerrit.ovirt.org/38491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Bronheim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list