Change in vdsm[master]: stomp: outgoing connection to a broker

ykaplan at redhat.com ykaplan at redhat.com
Wed Jun 10 15:02:42 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: stomp: outgoing connection to a broker
......................................................................


Patch Set 27:

(2 comments)

https://gerrit.ovirt.org/#/c/38819/27/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 67:         self._sub_dests = sub_map
Line 68:         self._req_dest = req_dest
Line 69:         self._sub_ids = {}
Line 70:         request_queues = config.get('addresses', 'request_queues')
Line 71:         self.request_queues = request_queues.split(",")
> It needs to stay as it is. Oneliner is longer than 80.
pep8 is not a good enough reason to have another variable, you can use '/' to split the line...
Line 72:         self._commands = {
Line 73:             stomp.Command.CONNECT: self._cmd_connect,
Line 74:             stomp.Command.SEND: self._cmd_send,
Line 75:             stomp.Command.SUBSCRIBE: self._cmd_subscribe,


https://gerrit.ovirt.org/#/c/38819/27/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 208:             sslctx = self._createSSLContext()
Line 209:             sock = socket.socket()
Line 210:             sock.connect((broker_address, broker_port))
Line 211:             if sslctx:
Line 212:                 sock = sslctx.wrapSocket(sock)
> Your patches is not merged so I am not able to use it here. We can have sep
But you still have that method (create_socket) in jsonrpchelper if I remember correctly, I will fix my patch on top of this.
Line 213: 
Line 214:             self._broker_client = StompClient(sock, self._reactor)
Line 215:             for destination in request_queues.split(","):
Line 216:                 self.subscriptions[destination] = StompRpcServer(


-- 
To view, visit https://gerrit.ovirt.org/38819
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list