Change in vdsm[master]: virt: memory hotplug for vm

ofrenkel at redhat.com ofrenkel at redhat.com
Wed Jun 10 14:20:07 UTC 2015


Omer Frenkel has posted comments on this change.

Change subject: virt: memory hotplug for vm
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/40549/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2175:         self._devices[hwclass.MEMORY].append(device)
Line 2176:         with self._confLock:
Line 2177:             self.conf['devices'].append(memParams)
Line 2178:         self.saveState()
Line 2179:         self._getUnderlyingMemoryDeviceInfo()
> maybe not.
verified in both case updated information returned from libvirt
Line 2180: 
Line 2181:         hooks.after_memory_hotplug(deviceXml)
Line 2182: 
Line 2183:         return {'status': doneCode, 'vmList': self.status()}


-- 
To view, visit https://gerrit.ovirt.org/40549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list