Change in vdsm[master]: Separate MOM to an external process

dkuznets at redhat.com dkuznets at redhat.com
Wed Jun 10 09:14:22 UTC 2015


Dima Kuznetsov has posted comments on this change.

Change subject: Separate MOM to an external process
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/41602/8/init/systemd/mom-vdsm.service.in
File init/systemd/mom-vdsm.service.in:

Line 6: 
Line 7: [Service]
Line 8: Type=simple
Line 9: LimitCORE=infinity
Line 10: ExecStart=/usr/sbin/momd -c /etc/vdsm/mom.conf
> consider to use the daemonAdapter that being used for vdsmd and supervdsmd 
systemd lets you control nice with the Nice= parameter in the unit file, and the out/err go to journalctl.

I think it is better to use the standard systemd facilities rather than rely on deamonAdapter.
Line 11: Restart=on-failure
Line 12: RestartSec=10
Line 13: User=@VDSMUSER@
Line 14: Group=@VDSMGROUP@


Line 10: ExecStart=/usr/sbin/momd -c /etc/vdsm/mom.conf
Line 11: Restart=on-failure
Line 12: RestartSec=10
Line 13: User=@VDSMUSER@
Line 14: Group=@VDSMGROUP@
> why does it run as vdsm user? it contains all its sudoer permissions.. bett
+1
Line 15: TimeoutStopSec=@SERVICE_STOP_TIMEOUT@
Line 16: 
Line 17: [Install]


-- 
To view, visit https://gerrit.ovirt.org/41602
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99b81d21080834b7031824dab0a26f45e7eac7af
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list