Change in vdsm[master]: hooks: Open vSwitch configurator

danken at redhat.com danken at redhat.com
Wed Jun 10 08:59:24 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
......................................................................


Patch Set 38:

(1 comment)

https://gerrit.ovirt.org/#/c/40312/38/vdsm_hooks/ovs/ovs_after_get_stats.py
File vdsm_hooks/ovs/ovs_after_get_stats.py:

Line 35:     running_config = RunningConfig()
Line 36: 
Line 37:     for network, attrs in running_config.networks.items():
Line 38:         if rget(attrs, ('custom', 'ovs')):
Line 39:             if attrs.get('vlan') is not None:
'vlan' in attrs

would be more readable
Line 40:                 continue
Line 41:             else:
Line 42:                 interface = attrs.get('nic') or attrs.get('bonding')
Line 43:             ovs_networks_stats[network] = stats[interface]


-- 
To view, visit https://gerrit.ovirt.org/40312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 38
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list