Change in vdsm[master]: Add support for KSM and CpuTune calls to XMLRPC for MOM to use

ykaplan at redhat.com ykaplan at redhat.com
Wed Jun 10 08:25:41 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: Add support for KSM and CpuTune calls to XMLRPC for MOM to use
......................................................................


Patch Set 6: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/41571/6/vdsm/API.py
File vdsm/API.py:

Line 1645: 
Line 1646:     def setKsmTune(self, tuningParams):
Line 1647:         try:
Line 1648:             superVdsm = supervdsm.getProxy()
Line 1649:             superVdsm.ksmTune(tuningParams)
> MOM used to call supervdsm directly through vdsm's connection, because it h
Please be compatible to rest of the code and just use:
supervdsm.getProxy().ksmTune(tuningParams)
superVdsm is an unnecessary variable and just makes it more complex.
Line 1650:             return dict(status=doneCode)
Line 1651:         except:
Line 1652:             return errCode['ksmErr']
Line 1653: 


https://gerrit.ovirt.org/#/c/41571/6/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 533: 
Line 534: ##
Line 535: # @KsmTuneParams:
Line 536: #
Line 537: # Parameters for controling KSM.
/s/controling/controlling
Line 538: #
Line 539: # @run:              The action: 0 nothing, 1 merge pages, 2 unmerge pages.
Line 540: #
Line 541: # @sleep_millisecs:  The wait time between page scans.


Line 551: # @Host.setKsmTune:
Line 552: #
Line 553: # Set variables for controling KSM mode and aggresivity.
Line 554: #
Line 555: # @tuningParams:     This argument contains a dictionary where keys
/s/This argument contains a dictionary.../a dictionary...
Line 556: #                    represent variable names and values
Line 557: #                    contain the values for controlling KSM.
Line 558: #
Line 559: # Since: 4.17.0


-- 
To view, visit https://gerrit.ovirt.org/41571
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd318b50abf8605c2584cb3b5316e2ca2ac4f5ef
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list