Change in vdsm[master]: status: logging status values before sending event
mskrivan at redhat.com
mskrivan at redhat.com
Tue Jun 9 13:36:45 UTC 2015
Michal Skrivanek has posted comments on this change.
Change subject: status: logging status values before sending event
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/41380/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 401: if 'exitReason' in self.conf:
Line 402: stats['exitReason'] = self.conf['exitReason']
Line 403:
Line 404: self.log.debug('Last status %s and evaluated status %s',
Line 405: self.lastStatus, vm_status)
> I was asked by mskrivanek to log both.
yeah, to actually understand what is the reported status from libvirt. Point is to understand where we (by mistake) hide/change things incorrectly
Line 406: self._notify('VM_status', stats)
Line 407:
Line 408: def _notify(self, operation, params):
Line 409: sub_id = '|virt|%s|%s' % (operation, self.id)
--
To view, visit https://gerrit.ovirt.org/41380
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e266759ba0310dd83d6b65d9e3a63caacc0b637
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list