Change in vdsm[master]: hooks: noipspoof: allow multiple interfaces

danken at redhat.com danken at redhat.com
Tue Jun 9 10:57:29 UTC 2015


Dan Kenigsberg has uploaded a new change for review.

Change subject: hooks: noipspoof: allow multiple interfaces
......................................................................

hooks: noipspoof: allow multiple interfaces

In this patch, the specified IPs are set on all interfaces. Note that
this simplicty approach lets one interface spoof the IP of another.

Change-Id: I2a9d18df8bb0fa17907d68fbf3c0d6718843ae48
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm_hooks/noipspoof/noipspoof.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/42078/1

diff --git a/vdsm_hooks/noipspoof/noipspoof.py b/vdsm_hooks/noipspoof/noipspoof.py
index 54bd9ac..a8571dd 100755
--- a/vdsm_hooks/noipspoof/noipspoof.py
+++ b/vdsm_hooks/noipspoof/noipspoof.py
@@ -55,8 +55,8 @@
     IPs = os.environ.get('noipspoof', '').split(',')
     if IPs:
         domxml = hooking.read_domxml()
-        interface, = domxml.getElementsByTagName('interface')
-        replaceMacSpoofingFilter(interface, IPs)
+        for interface in domxml.getElementsByTagName('interface'):
+            replaceMacSpoofingFilter(interface, IPs)
         hooking.write_domxml(domxml)
 
 


-- 
To view, visit https://gerrit.ovirt.org/42078
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a9d18df8bb0fa17907d68fbf3c0d6718843ae48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list