Change in vdsm[master]: vm: remove dup initialization of Vm._guestSockFile

danken at redhat.com danken at redhat.com
Mon Jun 8 20:36:55 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: remove dup initialization of Vm._guestSockFile
......................................................................


vm: remove dup initialization of Vm._guestSockFile

In Vm class' __init__, guestSockFile is initialized,
and the re-initialized a few lines below with no use
of this field in between.

To reduce the confusion, this patch removes the first
useless initialization.

Change-Id: Ie8d959dfc3ddd96e9d019dd93394bf4390adf5cf
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40751
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/40751
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8d959dfc3ddd96e9d019dd93394bf4390adf5cf
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list